dandi / dandi-schema

Schemata for DANDI archive project
Apache License 2.0
7 stars 10 forks source link

adding dcite:Funder to fundingReferences #169

Closed djarecka closed 1 year ago

djarecka commented 1 year ago

treating dcite:Funder in the same way as dcite:Sponsor and adding it to the fundingReferences

fixes #168

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 20.00% and project coverage change: -5.82 :warning:

Comparison is base (ac230ce) 97.71% compared to head (94e9905) 91.90%.

:exclamation: Current head 94e9905 differs from pull request most recent head 06204dd. Consider uploading reports for the commit 06204dd to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #169 +/- ## ========================================== - Coverage 97.71% 91.90% -5.82% ========================================== Files 17 17 Lines 1751 1754 +3 ========================================== - Hits 1711 1612 -99 - Misses 40 142 +102 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `91.90% <20.00%> (-5.82%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/dandi/dandi-schema/pull/169?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi) | Coverage Δ | | |---|---|---| | [dandischema/tests/test\_datacite.py](https://codecov.io/gh/dandi/dandi-schema/pull/169?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi#diff-ZGFuZGlzY2hlbWEvdGVzdHMvdGVzdF9kYXRhY2l0ZS5weQ==) | `49.45% <ø> (-50.55%)` | :arrow_down: | | [dandischema/datacite.py](https://codecov.io/gh/dandi/dandi-schema/pull/169?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi#diff-ZGFuZGlzY2hlbWEvZGF0YWNpdGUucHk=) | `49.55% <20.00%> (-45.90%)` | :arrow_down: | ... and [1 file with indirect coverage changes](https://codecov.io/gh/dandi/dandi-schema/pull/169/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi) Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

satra commented 1 year ago

did you see this PR #167 ?

djarecka commented 1 year ago

I saw #167, but before you added the Funder commits...