dandi / dandi-schema

Schemata for DANDI archive project
Apache License 2.0
7 stars 10 forks source link

CI: adding datacite validation #181

Closed djarecka closed 1 year ago

djarecka commented 1 year ago

added publish=True to one test to enable datacite validation. The doi will be published on https://doi.test.datacite.org/ as Findable, so will not be able to remove it!

I'm creating doi with id = 000002 and random version = 0.0.{random.randrange(0, 9999)}

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 50.00% and project coverage change: -5.43 :warning:

Comparison is base (845cb17) 97.71% compared to head (7868ad3) 92.29%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #181 +/- ## ========================================== - Coverage 97.71% 92.29% -5.43% ========================================== Files 17 17 Lines 1751 1751 ========================================== - Hits 1711 1616 -95 - Misses 40 135 +95 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `92.29% <50.00%> (-5.43%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://app.codecov.io/gh/dandi/dandi-schema/pull/181?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi) | Coverage Δ | | |---|---|---| | [dandischema/tests/test\_datacite.py](https://app.codecov.io/gh/dandi/dandi-schema/pull/181?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi#diff-ZGFuZGlzY2hlbWEvdGVzdHMvdGVzdF9kYXRhY2l0ZS5weQ==) | `49.45% <50.00%> (-50.55%)` | :arrow_down: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/dandi/dandi-schema/pull/181/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

satra commented 1 year ago

i think it would be good to limit the publishing test to only the platform that dandiarchive uses, so we don't have to test it for all options and limit the number of published dois on the test site.

djarecka commented 1 year ago

@satra - you mean just to use for one of the linux containers we have, not adding a new one that is the same as dandiarchive uses, right?

satra commented 1 year ago

you mean just to use for one of the linux containers we have

yes, one of the containers that matches the dandiarchive deployment. we should ask @mvandenburgh - how we can make sure to always have a setting that's as close to, if not identical, to the deployment versions on heroku.

satra commented 1 year ago

closing this since #167 was merged.