dandi / dandi-schema

Schemata for DANDI archive project
Apache License 2.0
5 stars 8 forks source link

Add `__all__` to `__init__.py` #195

Closed jwodder closed 8 months ago

jwodder commented 8 months ago

Because all of the items in the __init__.py namespace are imported from other modules, if a user of dandischema imports or references these items via the top-level dandischema module and they have mypy configured with implicit_reexport = False, then mypy will produce an error. In order to fix this, we need to tell mypy that the items imported into __init__.py are intended for re-export via the __all__ variable.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (a7f2245) 97.61% compared to head (74334d2) 97.61%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #195 +/- ## ======================================= Coverage 97.61% 97.61% ======================================= Files 17 17 Lines 1758 1759 +1 ======================================= + Hits 1716 1717 +1 Misses 42 42 ``` | [Flag](https://app.codecov.io/gh/dandi/dandi-schema/pull/195/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/dandi/dandi-schema/pull/195/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi) | `97.61% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/dandi/dandi-schema/pull/195?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi) | Coverage Δ | | |---|---|---| | [dandischema/\_\_init\_\_.py](https://app.codecov.io/gh/dandi/dandi-schema/pull/195?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi#diff-ZGFuZGlzY2hlbWEvX19pbml0X18ucHk=) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.