search

dandi / dandi-schema

Schemata for DANDI archive project
Apache License 2.0
5 stars 8 forks source link

Give `version2tuple()` a better type annotation #208

Closed jwodder closed 7 months ago

jwodder commented 7 months ago

Also, remove superfluous function-level import of re (It's already imported at the top of the file).

Also, prevent the function from crashing when given a string with non-ASCII Unicode digits.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (68f4d1e) 97.61% compared to head (f302d27) 97.61%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #208 +/- ## ======================================= Coverage 97.61% 97.61% ======================================= Files 17 17 Lines 1760 1760 ======================================= Hits 1718 1718 Misses 42 42 ``` | [Flag](https://app.codecov.io/gh/dandi/dandi-schema/pull/208/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/dandi/dandi-schema/pull/208/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi) | `97.61% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

yarikoptic commented 7 months ago

LGTM, thanks!