dandi / dandi-schema

Schemata for DANDI archive project
Apache License 2.0
5 stars 8 forks source link

[pre-commit.ci] pre-commit autoupdate #219

Closed pre-commit-ci[bot] closed 5 months ago

pre-commit-ci[bot] commented 5 months ago

updates:

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (4423b41) 97.66% compared to head (ab58ab8) 97.66%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #219 +/- ## ======================================= Coverage 97.66% 97.66% ======================================= Files 18 18 Lines 1798 1798 ======================================= Hits 1756 1756 Misses 42 42 ``` | [Flag](https://app.codecov.io/gh/dandi/dandi-schema/pull/219/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/dandi/dandi-schema/pull/219/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi) | `97.66% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

yarikoptic commented 5 months ago

@jwodder WDYT? should we go ahead with it or somehow tune config to avoid side-effects from upgrade?

jwodder commented 5 months ago

@yarikoptic

somehow tune config to avoid side-effects from upgrade?

Do you mean somehow suppressing the formatting changes due to the new version of black? Why would we want to do that?

yarikoptic commented 5 months ago

in principle -- to avoid possible conflicts with other outstanding PRs

jwodder commented 5 months ago

@yarikoptic Unless there's a way to trigger an update of this PR later (Is there?), I think it'd be easiest to merge this as soon as possible, then update all other outstanding PRs via rebasing and running pre-commit run -a.