search

dandi / dandi-schema

Schemata for DANDI archive project
Apache License 2.0
5 stars 8 forks source link

Move `TempKlass`es outside of test functions #224

Closed jwodder closed 5 months ago

jwodder commented 5 months ago

Closes #223.

This fixes the reported mypy crash. I was unable to produce an MVCE.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (9b9c283) 97.66% compared to head (d96af2f) 97.66%. Report is 3 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #224 +/- ## ======================================= Coverage 97.66% 97.66% ======================================= Files 18 18 Lines 1799 1799 ======================================= Hits 1757 1757 Misses 42 42 ``` | [Flag](https://app.codecov.io/gh/dandi/dandi-schema/pull/224/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/dandi/dandi-schema/pull/224/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi) | `97.66% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

yarikoptic commented 5 months ago

THANK YOU!