dandi / dandi-schema

Schemata for DANDI archive project
Apache License 2.0
7 stars 10 forks source link

Test against PR in dandi-cli to be compatible with pydantic v2 #225

Closed yarikoptic closed 8 months ago

yarikoptic commented 9 months ago

Now that dandi-schema is only pydantic 2.0 compatible, and while we are awaiting on dandi-archive to get ready -- there is probably no point to test against released/master dandi-cli -- just makes CI red hiding possible other fails.

We need to test against the dandi-cli in that PR for now

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (e6cc5a0) 97.54% compared to head (6f33125) 97.54%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #225 +/- ## ======================================= Coverage 97.54% 97.54% ======================================= Files 16 16 Lines 1669 1669 ======================================= Hits 1628 1628 Misses 41 41 ``` | [Flag](https://app.codecov.io/gh/dandi/dandi-schema/pull/225/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/dandi/dandi-schema/pull/225/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi) | `97.54% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

yarikoptic commented 8 months ago

no longer needed AFAIK