search

dandi / dandi-schema

Schemata for DANDI archive project
Apache License 2.0
7 stars 10 forks source link

Add ResourceType enum and associate with Resource model #232

Closed bendichter closed 8 months ago

bendichter commented 8 months ago

fix #231

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.58%. Comparing base (e6cc5a0) to head (2f8e27f).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #232 +/- ## ========================================== + Coverage 97.54% 97.58% +0.04% ========================================== Files 16 16 Lines 1669 1701 +32 ========================================== + Hits 1628 1660 +32 Misses 41 41 ``` | [Flag](https://app.codecov.io/gh/dandi/dandi-schema/pull/232/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/dandi/dandi-schema/pull/232/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi) | `97.58% <100.00%> (+0.04%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

satra commented 8 months ago

@bendichter - since this will create a new schema you should increment that to and make the necessary changes to consts.py

bendichter commented 8 months ago

I'm not familiar with the merge protocol here. Is this all that's needed? Should I also add an entry to the CHANGELOG.md file?

satra commented 8 months ago

I'm not familiar with the merge protocol here. Is this all that's needed? Should I also add an entry to the CHANGELOG.md file?

yes that's all that was needed. CHANGELOG is autogenerated+updated on release.

bendichter commented 8 months ago

OK great, now what's the process for propagating this change to the medator?

satra commented 8 months ago

@bendichter - dandi-archive may need a schema bump.

satra commented 8 months ago

however the auto release failed in this repo, so the version of auto may need to be updated to fix that.

jwodder commented 8 months ago

@satra I suspect the auto failure has the same solution as https://github.com/nipy/heudiconv/pull/746.