search

dandi / dandi-schema

Schemata for DANDI archive project
Apache License 2.0
7 stars 10 forks source link

GitHub tests.yml CI: explicitly specify macos-12 and use python 3.11 to test against dandi-cli #238

Closed yarikoptic closed 7 months ago

yarikoptic commented 7 months ago

The arm64 one seems to lack pythons 3.8 and 3.9. Ref: https://github.com/dandi/dandi-schema/pull/236#issuecomment-2073369726

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.39%. Comparing base (dc15401) to head (1ad6023).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #238 +/- ## ======================================= Coverage 87.39% 87.39% ======================================= Files 16 16 Lines 1722 1722 ======================================= Hits 1505 1505 Misses 217 217 ``` | [Flag](https://app.codecov.io/gh/dandi/dandi-schema/pull/238/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/dandi/dandi-schema/pull/238/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi) | `87.39% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

yarikoptic commented 7 months ago

so it didn't help -- still goes for arm64: image

for now let's just keep good old macos-12 -- since not yet announced "deprecated" , I think we would have some time.

yarikoptic commented 7 months ago

ok -- for macos-12 ones we now got tests actually ran without bailing, so provides part of the solution. But I do not get why all the rest fail whenever they do not fail e.g. in https://github.com/dandi/dandi-schema/pull/236 . Need to have a fresh look tomorrow.

candleindark commented 7 months ago

But I do not get why all the rest fail whenever they do not fail e.g. in #236 . Need to have a fresh look tomorrow.

All the failed tests seem to be failing the email requirement put in #235 which is very strange. I don't know why changing Python version has anything to do with these errors at this point, and I am not able to replicate the problem locally.

yarikoptic commented 7 months ago

ok, we need to undig CI from redness. I think this PR should be a step forward so I will merge