search

dandi / dandi-schema

Schemata for DANDI archive project
Apache License 2.0
5 stars 8 forks source link

metadata: anatomy #61

Open satra opened 2 years ago

satra commented 2 years ago

This is a potential regression in VJSF where anyOf may no longer be supported.

Discussed in https://github.com/dandi/helpdesk/discussions/20

Originally posted by **bendichter** July 19, 2021 How do I add an UBERON ID for an anatomical structure? ![image](https://user-images.githubusercontent.com/844306/126202385-30f12c2d-de78-4315-b364-7e935194bba7.png)
satra commented 2 years ago

@bendichter - digging into this.

waxlamp commented 2 years ago

Do we need to file an issue upstream?

satra commented 2 years ago

i did file an issue upstream, but i can change the schema locally to address this in the short term. i'm looking into that now.

waxlamp commented 2 years ago

i did file an issue upstream, but i can change the schema locally to address this in the short term. i'm looking into that now.

Could you link the upstream issue here?

satra commented 2 years ago

https://github.com/koumoul-dev/vuetify-jsonschema-form/issues/278.

also #60 addresses this issue without upstream changes, and is probably a cleaner solution in the short term. turns out format=uri in json accepts any string and is not restricting input to be an http(s) url. the latest commit in that PR refactors most urls into this pattern.

we should be releasing that PR sometime today, which would require change of base-schema to 0.5.0