dandi / dandisets-healthstatus

Healthchecks of dandisets and support libraries (pynwb and matnwb)
0 stars 1 forks source link

Doesn't actually store updated status for a file while running test-files #47

Closed yarikoptic closed 1 year ago

yarikoptic commented 1 year ago

We have 1 file (across all dandisets) with false positive for pynwb but rerunning testing on it doesn't save its result:

(venv) (base) dandi@drogon:~/cronlib/dandisets-healthstatus$ healthstatus test-files --save-results pynwb_open_load_ns /mnt/backup/dandi/dandisets-healthstatus/dandisets-fuse/000296/sub-2777065067444737009/sub-2777065067444737009_ses-20180714T140121_ophys.nwb
2023-03-29 13:02:36 [DEBUG   ] Using selector: EpollSelector
2023-03-29 13:02:36 [INFO    ] Scanning Dandiset 000296
2023-03-29 13:02:43 [INFO    ] Testing /mnt/backup/dandi/dandisets-healthstatus/dandisets-fuse/000296/sub-2777065067444737009/sub-2777065067444737009_ses-20180714T140121_ophys.nwb ...
2023-03-29 13:02:43 [DEBUG   ] Using selector: EpollSelector
2023-03-29 13:02:49 [INFO    ] /mnt/backup/dandi/dandisets-healthstatus/dandisets-fuse/000296/sub-2777065067444737009/sub-2777065067444737009_ses-20180714T140121_ophys.nwb: PASS
(venv) (base) dandi@drogon:~/cronlib/dandisets-healthstatus$ git diff
diff --git a/results/000296/status.yaml b/results/000296/status.yaml
index b997254..0567975 100644
--- a/results/000296/status.yaml
+++ b/results/000296/status.yaml
@@ -1,7 +1,8 @@
+dandiset: 000296
 dandiset_version: 77584537e50726e3378d20dcdea9c032237dbe86
-last_run: 2023-02-27 18:57:20.986796-05:00
+last_run: '2023-02-27T18:57:20.986796-05:00'
 last_run_duration: 619473.428003
-last_run_ended: 2023-03-06 23:01:54.414799-05:00
+last_run_ended: '2023-03-06T23:01:54.414799-05:00'
 nassets: 1278
 tests:
 - assets_nok:
@@ -2571,5 +2572,8 @@ tests:
 untested: []
 versions:
   hdmf: 3.5.1
+  hdmf_lineno: '2573'
   matnwb: v2.6.0.0
+  matnwb_lineno: '2574'
   pynwb: 2.2.0
+  pynwb_lineno: '2575'

(for lineno there is a dedicated #46 ) and file remains in _nok

(venv) (base) dandi@drogon:~/cronlib/dandisets-healthstatus$ git grep -B1 -e name -e sub-2777065067444737009_ses-20180714T140121_ophys  results/000296/status.yaml
results/000296/status.yaml-- assets_nok:
results/000296/status.yaml:  - sub-2777065067444737009/sub-2777065067444737009_ses-20180714T140121_ophys.nwb
--
results/000296/status.yaml-  assets_timeout: []
results/000296/status.yaml:  name: pynwb_open_load_ns
--
results/000296/status.yaml-  - sub-2756959798039953379/sub-2756959798039953379_ses-20220309T133653_ophys.nwb
results/000296/status.yaml:  - sub-2777065067444737009/sub-2777065067444737009_ses-20180714T140121_ophys.nwb
--
results/000296/status.yaml-  assets_timeout: []
results/000296/status.yaml:  name: matnwb_nwbRead