dandi / dandisets-healthstatus

Healthchecks of dandisets and support libraries (pynwb and matnwb)
0 stars 1 forks source link

Do store/expose logs for (at least failed) runs. #72

Open yarikoptic opened 4 months ago

yarikoptic commented 4 months ago

Prior ref:

So we do store the logs from each run combined across all assets, e.g.

(venv) dandi@drogon:~/cronlib/dandisets-healthstatus$ ls -lta  results/000003/ | head -n 6
total 4280
drwxr-xr-x 331 dandi dandi 12288 Mar  6 10:36 ..
drwxr-xr-x   2 dandi dandi 86016 Mar  6 10:36 .
-rw-r--r--   1 dandi dandi 16530 Mar  6 10:36 status.yaml
-rw-r--r--   1 dandi dandi 90740 Jan  6 00:34 2024.01.03.12.21.19_matnwb_nwbRead_errors.log
-rw-r--r--   1 dandi dandi  1125 Nov 18 02:13 2023.11.18.00.50.33_matnwb_nwbRead_errors.log
(venv) dandi@drogon:~/cronlib/dandisets-healthstatus$ grep '^Asset' results/000003/2024.01.03.12.21.19_matnwb_nwbRead_errors.log | nl | tail -n 2
    80  Asset: sub-YutaMouse57/sub-YutaMouse57_ses-YutaMouse57-161014_behavior+ecephys.nwb
    81  Asset: sub-YutaMouse57/sub-YutaMouse57_ses-YutaMouse57-161016_behavior+ecephys.nwb

so to access a fail for some sample failing healthcheck, someone needs to

which is quite cumbersome. So, ideally we should have them committed to git and pushed directly here on github. The problem is that we can't keep history growing since then repo would grow too large too quickly. But I think we will be ok if we keep only the single state commit and rewrite it. So let's

In the README.md here, per each dandiset row, add there a convenience link to the logs, so row looks like

000019 [logs] | 30 passed, 1 failed, 0 timed out | 0 passed, 31 failed, 0 timed out | —

Ideally, if it is feasible, if we could as a comment in results/ yaml files urls to logs, like

tests:
- assets_nok:
  - sub-EC2/sub-EC2_ses-EC2-B1.nwb  # https://github.com/dandi/dandisets-healthstatus-logs/blob/main/000019/sub-EC2/sub-EC2_ses-EC2-B1.nwb/pynwb_open_load_ns_errors.txt
  assets_ok:
  - sub-EC2/sub-EC2_ses-EC2-B105.nwb
  name: pynwb_open_load_ns

that would have been great, but I have not looked how feasible it is yet.

yarikoptic commented 3 months ago

ping on this

yarikoptic commented 3 months ago

@rly please sign up to this issue to know when you can get to the logs seamlessly