Closed yarikoptic closed 1 month ago
this regex "s,.*\(is .*\) in \S.*,\1,g"
is the "GNU sed" regex, so it escapes the group etc, in python it would be the difference, not sure in OSX
All features requested for the table are complete in https://github.com/dandi/dandisets-linkml-status/pull/1. However, I want to remove the following one. The required condition in the feature is never true for any of the existing dandisets.
- [x] if draft and published version have the same "modified" and "status", then do not produce DRAFT version row
The modified
timestamp for a draft version seems to be never the same as the corresponding latest published version. Take a look at the "000017" dandisets @ https://github.com/candleindark/dandisets-linkml-status/blob/init/dandi-reports/summary.md, and you will that the draft version is essentially the same as the latest published version, but they have different timestamp.
In place of the condition you suggested, we may just take away a draft version if it has the status of Published
. However, my recommendation would be not taking away any draft version at all. Even for a draft version with the status of Published
, its metadata is not exactly the same as the metadata of the corresponding latest published version.
FTR: (per @yarikoptic's approval) The outputting of validation reports on draft version is now unconditional, i.e. the validation reports of the draft version of all dandiset will be outputted.
@yarikoptic I am closing this issue. All requested features for the summary table in this issue has been implemented. Additional feature requests for the table can be done by filing a new issue, such as https://github.com/dandi/dandisets-linkml-status-tools/issues/14.
Example/specification of the table to produce
[x] "api_status" as API returns in the listing of dandisets, e.g. "Valid" in both cases here:
"most_recent_published_version": { "version": "0.240106.0043", "name": "Mapping the Neural Dynamics of Locomotion across the Drosophila Brain", "asset_count": 18, "size": 609568504598, "status": "Valid", "created": "2024-01-06T00:43:26.749476Z", "modified": "2024-01-06T00:43:28.815333Z" }, "draft_version": { "version": "draft", "name": "Mapping the Neural Dynamics of Locomotion across the Drosophila Brain", "asset_count": 18, "size": 609568504598, "status": "Invalid", "created": "2023-12-10T10:22:46.559944Z", "modified": "2024-05-18T17:08:27.003540Z" }
schemaVersion
"s,.*\(is .*\) in \S.*,\1,g"
which ATM produces across all dandisets: