dandi / dandisets-linkml-status-tools

Tools for reporting the status of the translation of DANDI schemas from Pydantic definitions to LinkML definitions
MIT License
0 stars 2 forks source link

Table to produce #2

Closed yarikoptic closed 1 month ago

yarikoptic commented 2 months ago

Example/specification of the table to produce

dandiset version schema_version api_status modified pydantic linkml
000727 0.240106.0043 0.6.4 Valid 2024-01-06T00:43:28.815333Z 4 (1 value_error, 3 string_pattern_mismatch) 14 (1 + 13)
000727 draft 0.6.4 Invalid 2024-05-18T17:08:27.003540Z ???


- [x] and then for linkml reference, just count the number of such different errors. Most of the time it would be 2 ATM since they all have that "is not of type string" and "Additional propert
yarikoptic commented 2 months ago

this regex "s,.*\(is .*\) in \S.*,\1,g" is the "GNU sed" regex, so it escapes the group etc, in python it would be the difference, not sure in OSX

candleindark commented 2 months ago

All features requested for the table are complete in https://github.com/dandi/dandisets-linkml-status/pull/1. However, I want to remove the following one. The required condition in the feature is never true for any of the existing dandisets.

  • [x] if draft and published version have the same "modified" and "status", then do not produce DRAFT version row

The modified timestamp for a draft version seems to be never the same as the corresponding latest published version. Take a look at the "000017" dandisets @ https://github.com/candleindark/dandisets-linkml-status/blob/init/dandi-reports/summary.md, and you will that the draft version is essentially the same as the latest published version, but they have different timestamp.

In place of the condition you suggested, we may just take away a draft version if it has the status of Published. However, my recommendation would be not taking away any draft version at all. Even for a draft version with the status of Published, its metadata is not exactly the same as the metadata of the corresponding latest published version.

candleindark commented 2 months ago

FTR: (per @yarikoptic's approval) The outputting of validation reports on draft version is now unconditional, i.e. the validation reports of the draft version of all dandiset will be outputted.

candleindark commented 1 month ago

@yarikoptic I am closing this issue. All requested features for the summary table in this issue has been implemented. Additional feature requests for the table can be done by filing a new issue, such as https://github.com/dandi/dandisets-linkml-status-tools/issues/14.