search

dandi / dandisets

737 Dandisets, 812.2 TB total. DataLad super-dataset of all Dandisets from https://github.com/dandisets
10 stars 0 forks source link

Workaround: do not try to git rm within .zarr/ which must be submodule #267

Closed yarikoptic closed 1 year ago

yarikoptic commented 1 year ago

The rationale for such behavior is not diagnosed yet but this should provide a workaround so process does not crash for no good reason.

Ref: https://github.com/dandi/dandisets/issues/266

pre-commit might add another reformatting to this commit :-/

codecov[bot] commented 1 year ago

Codecov Report

Base: 77.32% // Head: 77.25% // Decreases project coverage by -0.07% :warning:

Coverage data is based on head (a6e2c37) compared to base (d0f7d10). Patch coverage: 25.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## draft #267 +/- ## ========================================== - Coverage 77.32% 77.25% -0.08% ========================================== Files 14 14 Lines 2064 2066 +2 Branches 348 349 +1 ========================================== Hits 1596 1596 - Misses 338 339 +1 - Partials 130 131 +1 ``` | [Impacted Files](https://codecov.io/gh/dandi/dandisets/pull/267?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi) | Coverage Δ | | |---|---|---| | [tools/backups2datalad/adataset.py](https://codecov.io/gh/dandi/dandisets/pull/267/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi#diff-dG9vbHMvYmFja3VwczJkYXRhbGFkL2FkYXRhc2V0LnB5) | `76.57% <25.00%> (-0.70%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

yarikoptic commented 1 year ago

I think @jwodder figured the underlying issue out, so I will just close - we better react/fix dataset if encounter again.