dandi / dandisets

737 Dandisets, 812.2 TB total. DataLad super-dataset of all Dandisets from https://github.com/dandisets
10 stars 0 forks source link

Don't expect JSON in /publish/ response #279

Closed jwodder closed 1 year ago

yarikoptic commented 1 year ago

FWIW: I was testing locally and confirming that resolved errorring out test_backups2datalad/test_core.py::test_4 on empty json but then it finally errorred out with

E       ValueError: Dandiset 204689 is Pending: {
E           "asset_validation_errors": [],
E           "version_validation_errors": []
E       }

CI finished with similar errors here. Meanwhile will disable cron job to avoid errors

jwodder commented 1 year ago

@yarikoptic Errors with publishing (either due to the lack of this PR or in the tests) don't affect the actual running of the backup script, as /publish/ is only called in tests to prepare Dandisets with multiple versions.

yarikoptic commented 1 year ago

ah, right -- reenabling CRON.

yarikoptic commented 1 year ago

do you see how to finish this one up so code gets green again and I could test my changes the #278?

jwodder commented 1 year ago

@yarikoptic If the tests don't pass after rerunning, we may have to file a bug report with the Archive saying that validation is taking too long.

yarikoptic commented 1 year ago

hm... that is validation on the https://gui-staging.dandiarchive.org/ instance right? if we end up failing -- indeed please file an issue with the archive.

codecov[bot] commented 1 year ago

Codecov Report

Base: 77.31% // Head: 77.50% // Increases project coverage by +0.19% :tada:

Coverage data is based on head (9500d64) compared to base (0a2b6d1). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## draft #279 +/- ## ========================================== + Coverage 77.31% 77.50% +0.19% ========================================== Files 14 14 Lines 2098 2098 Branches 346 346 ========================================== + Hits 1622 1626 +4 + Misses 340 339 -1 + Partials 136 133 -3 ``` | [Impacted Files](https://codecov.io/gh/dandi/dandisets/pull/279?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi) | Coverage Δ | | |---|---|---| | [tools/backups2datalad/adandi.py](https://codecov.io/gh/dandi/dandisets/pull/279/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi#diff-dG9vbHMvYmFja3VwczJkYXRhbGFkL2FkYW5kaS5weQ==) | `76.92% <100.00%> (+1.53%)` | :arrow_up: | | [tools/backups2datalad/asyncer.py](https://codecov.io/gh/dandi/dandisets/pull/279/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi#diff-dG9vbHMvYmFja3VwczJkYXRhbGFkL2FzeW5jZXIucHk=) | `80.28% <0.00%> (+0.57%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

yarikoptic commented 1 year ago

Hmm ok, passed