Closed jwodder closed 1 year ago
@yarikoptic Errors with publishing (either due to the lack of this PR or in the tests) don't affect the actual running of the backup script, as /publish/
is only called in tests to prepare Dandisets with multiple versions.
ah, right -- reenabling CRON.
do you see how to finish this one up so code gets green again and I could test my changes the #278?
@yarikoptic If the tests don't pass after rerunning, we may have to file a bug report with the Archive saying that validation is taking too long.
hm... that is validation on the https://gui-staging.dandiarchive.org/ instance right? if we end up failing -- indeed please file an issue with the archive.
Base: 77.31% // Head: 77.50% // Increases project coverage by +0.19%
:tada:
Coverage data is based on head (
9500d64
) compared to base (0a2b6d1
). Patch coverage: 100.00% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Hmm ok, passed
FWIW: I was testing locally and confirming that resolved errorring out test_backups2datalad/test_core.py::test_4 on empty json but then it finally errorred out with
CI finished with similar errors here. Meanwhile will disable cron job to avoid errors