dandi / dandisets

735 Dandisets, 812.2 TB total. DataLad super-dataset of all Dandisets from https://github.com/dandisets
10 stars 0 forks source link

Add lower-level logging of unexpected exceptions #294

Closed jwodder closed 1 year ago

jwodder commented 1 year ago

Part of #293.

I was able to produce an MVCE of the problem (which I reported as a bug in anyio: https://github.com/agronholm/anyio/issues/490). Apparently, some exception is getting raised inside stream_null_command() — either immediately inside it or within something that's using it as a context manager — but I have no idea what that exception might be. I've added more logging for now.

codecov[bot] commented 1 year ago

Codecov Report

Base: 76.85% // Head: 76.71% // Decreases project coverage by -0.14% :warning:

Coverage data is based on head (0d76b68) compared to base (725366f). Patch coverage: 75.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## draft #294 +/- ## ========================================== - Coverage 76.85% 76.71% -0.15% ========================================== Files 14 14 Lines 2320 2323 +3 Branches 373 373 ========================================== - Hits 1783 1782 -1 - Misses 391 393 +2 - Partials 146 148 +2 ``` | [Impacted Files](https://codecov.io/gh/dandi/dandisets/pull/294?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi) | Coverage Δ | | |---|---|---| | [tools/backups2datalad/adataset.py](https://codecov.io/gh/dandi/dandisets/pull/294/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi#diff-dG9vbHMvYmFja3VwczJkYXRhbGFkL2FkYXRhc2V0LnB5) | `77.77% <0.00%> (ø)` | | | [tools/backups2datalad/aioutil.py](https://codecov.io/gh/dandi/dandisets/pull/294/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi#diff-dG9vbHMvYmFja3VwczJkYXRhbGFkL2Fpb3V0aWwucHk=) | `81.41% <81.81%> (-0.95%)` | :arrow_down: | | [tools/backups2datalad/asyncer.py](https://codecov.io/gh/dandi/dandisets/pull/294/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi#diff-dG9vbHMvYmFja3VwczJkYXRhbGFkL2FzeW5jZXIucHk=) | `78.83% <0.00%> (-0.56%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

yarikoptic commented 1 year ago

That is great! Thank you @jwodder -- I will merge, and rerun asap (want to make sure zarrs are clean etc).