search

dandi / dandisets

735 Dandisets, 812.2 TB total. DataLad super-dataset of all Dandisets from https://github.com/dandisets
10 stars 0 forks source link

Don't use TextReceiveStream as a context manager #299

Closed jwodder closed 1 year ago

jwodder commented 1 year ago

This is a guess at a possible way to deal with #293.

With this change, CancelledErrors raised inside the loop will no longer cause the Stream to be closed; that is instead delayed to kill_on_error().

jwodder commented 1 year ago

@yarikoptic The tests are failing because the test Dandisets aren't validating in time.

yarikoptic commented 1 year ago

@yarikoptic The tests are failing because the test Dandisets aren't validating in time.

is it some new behavior of dandi-archive? then please alert dandi-archive team/file an issue.

jwodder commented 1 year ago

@yarikoptic It's an old behavior which has resurfaced.

jwodder commented 1 year ago

@yarikoptic Issue filed: https://github.com/dandi/dandi-archive/issues/1365

yarikoptic commented 1 year ago

ok, let's hope there is no side effects and give it a shot