search

dandi / dandisets

735 Dandisets, 812.2 TB total. DataLad super-dataset of all Dandisets from https://github.com/dandisets
10 stars 0 forks source link

Trigger commit if not changes to zarr but we had only updated time stamp #322

Closed yarikoptic closed 1 year ago

yarikoptic commented 1 year ago

may be s3 gets something resulting in update but no content change. not entirely sure on the reason though

Tested on /mnt/backup/dandi/dandizarrs/a887df22-1254-46c8-84bc-c11703844978 which now has that commit

Not sure if this wold be ok to as if some operation errors out in syncing zarr that we do not commit (I would assume that exception would bubble up)

Closes #321

codecov[bot] commented 1 year ago

Codecov Report

Base: 75.88% // Head: 75.82% // Decreases project coverage by -0.07% :warning:

Coverage data is based on head (680a1d5) compared to base (7192da2). Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## draft #322 +/- ## ========================================== - Coverage 75.88% 75.82% -0.07% ========================================== Files 14 14 Lines 2397 2399 +2 Branches 380 381 +1 ========================================== Hits 1819 1819 - Misses 425 426 +1 - Partials 153 154 +1 ``` | [Impacted Files](https://codecov.io/gh/dandi/dandisets/pull/322?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi) | Coverage Δ | | |---|---|---| | [tools/backups2datalad/zarr.py](https://codecov.io/gh/dandi/dandisets/pull/322?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi#diff-dG9vbHMvYmFja3VwczJkYXRhbGFkL3phcnIucHk=) | `73.52% <50.00%> (-0.42%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

yarikoptic commented 1 year ago

I want to progress with backups, will assume that it is the way to go.