dandi / dandisets

735 Dandisets, 812.2 TB total. DataLad super-dataset of all Dandisets from https://github.com/dandisets
10 stars 0 forks source link

Use zarr_checksum package for computing Zarr checksums #326

Closed jwodder closed 1 year ago

jwodder commented 1 year ago

@AlmightyYakob wrote a package for computing Zarr checksums, including calculating checksums for a tree of individual file checksums, and to ensure consistency among the Dandi code base, it should be used in place of dandi-cli's ZCTree class.

codecov[bot] commented 1 year ago

Codecov Report

Base: 76.19% // Head: 75.82% // Decreases project coverage by -0.38% :warning:

Coverage data is based on head (cfc9ae4) compared to base (50d5167). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## draft #326 +/- ## ========================================== - Coverage 76.19% 75.82% -0.38% ========================================== Files 14 14 Lines 2399 2399 Branches 381 381 ========================================== - Hits 1828 1819 -9 - Misses 417 426 +9 Partials 154 154 ``` | [Impacted Files](https://codecov.io/gh/dandi/dandisets/pull/326?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi) | Coverage Δ | | |---|---|---| | [tools/backups2datalad/adataset.py](https://codecov.io/gh/dandi/dandisets/pull/326?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi#diff-dG9vbHMvYmFja3VwczJkYXRhbGFkL2FkYXRhc2V0LnB5) | `79.23% <100.00%> (ø)` | | | [tools/backups2datalad/zarr.py](https://codecov.io/gh/dandi/dandisets/pull/326?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi#diff-dG9vbHMvYmFja3VwczJkYXRhbGFkL3phcnIucHk=) | `73.52% <100.00%> (ø)` | | | [tools/backups2datalad/aioutil.py](https://codecov.io/gh/dandi/dandisets/pull/326?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi#diff-dG9vbHMvYmFja3VwczJkYXRhbGFkL2Fpb3V0aWwucHk=) | `72.63% <0.00%> (-3.16%)` | :arrow_down: | | [tools/backups2datalad/logging.py](https://codecov.io/gh/dandi/dandisets/pull/326?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi#diff-dG9vbHMvYmFja3VwczJkYXRhbGFkL2xvZ2dpbmcucHk=) | `85.00% <0.00%> (-2.50%)` | :arrow_down: | | [tools/backups2datalad/util.py](https://codecov.io/gh/dandi/dandisets/pull/326?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi#diff-dG9vbHMvYmFja3VwczJkYXRhbGFkL3V0aWwucHk=) | `77.14% <0.00%> (-1.43%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

yarikoptic commented 1 year ago

Great, thanks for being proactive!