Closed yarikoptic closed 1 year ago
fresh fiasco which forbids testing the fix:
2023-08-22T02:39:12+0000 [INFO ] datalad_installer Running: nd-configurerepo
I: This script requires root access. Since current user is not root, sudo will be used
I: Command netselect (from package netselect) is N/A.
I: Use with --install to get all necessary packages installed automatically
I: netselect (apt-get install netselect) needed to select the 'best' mirror was not found
I: Selecting the default repository: http://neuro.debian.net/debian
I: Generating /etc/apt/sources.list.d/neurodebian.sources.list
I: Updating APT listings, might take a few minutes
I: E: Malformed entry 3 in list file /etc/apt/sources.list.d/neurodebian.sources.list (Component)
E: The list of sources could not be read.
E: Update failed with exit code 0.
Traceback (most recent call last):
File "/opt/hostedtoolcache/Python/3.8.17/x64/bin/datalad-installer", line 8, in <module>
sys.exit(main())
File "/opt/hostedtoolcache/Python/3.8.17/x64/lib/python3.8/site-packages/datalad_installer.py", line 2778, in main
return manager.main(argv)
File "/opt/hostedtoolcache/Python/3.8.17/x64/lib/python3.8/site-packages/datalad_installer.py", line 763, in main
self.addcomponent(name=cr.name, **cr.kwargs)
File "/opt/hostedtoolcache/Python/3.8.17/x64/lib/python3.8/site-packages/datalad_installer.py", line 802, in addcomponent
component(self).provide(**kwargs)
File "/opt/hostedtoolcache/Python/3.8.17/x64/lib/python3.8/site-packages/datalad_installer.py", line 1233, in provide
runcmd("nd-configurerepo", *(extra_args or []))
File "/opt/hostedtoolcache/Python/3.8.17/x64/lib/python3.8/site-packages/datalad_installer.py", line 2627, in runcmd
return subprocess.run(arglist, check=True, **kwargs)
File "/opt/hostedtoolcache/Python/3.8.17/x64/lib/python3.8/subprocess.py", line 516, in run
raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['nd-configurerepo']' returned non-zero exit status 5.
Patch coverage: 100.00%
and project coverage change: -0.32%
:warning:
Comparison is base (
cde0fe2
) 76.21% compared to head (08cb97e
) 75.90%. Report is 100 commits behind head on draft.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Nice, tests are green now after the workaround in datalad installer. Let's proceed
This would mimic the "fix" introduced in dandi-cli in https://github.com/dandi/dandi-cli/pull/1311/files .
It is not entirely clear to me why such composition is necessary.
Good news is that no real releases should be effected and it is only fixing up for the purpose of the tests AFAIK likely to just overcome some race condition in dandi-archive (inquiring in https://github.com/dandi/dandi-cli/pull/1311/files#r1300838618 for more details)
Fixes #356