search

dandi / example-notebooks

https://www.dandiarchive.org/example-notebooks
Apache License 2.0
6 stars 17 forks source link

Visual Coding (Ophys) Tutorial #73

Closed CodyCBakerPhD closed 5 months ago

CodyCBakerPhD commented 6 months ago

@bendichter This is finally ready for review

We should hold off on merging (or I can fix post-merge) once the latest PyNWB has been released so I can update the frozen conda environment (currently pointing to a dev branch out of necessity around the stimulus group bug)

CodyCBakerPhD commented 6 months ago

Something interesting is that the GitHub preview for notebooks fully expands all HTML dropdowns by default - the biggest offenders of this seem to be the nested ROI links inside RoiReponseSeries types

bendichter commented 6 months ago

@CodyCBakerPhD wow, this is awesome! Did you say this was based on an original notebook Saskia gave you? Could you provide a link and explanation of that either in the README or in the notebook itself? Otherwise, looks great!

CodyCBakerPhD commented 6 months ago

@bendichter Added a blurb about the source notebook this was adapted from:

https://github.com/dandi/example-notebooks/pull/73/files#diff-be3f021c52135972f1a31460d2458d61177b2d72f39371ab39cdc376342b5bfdR11

bendichter commented 6 months ago

OK, this looks good to me. Let me know when the dependencies reach a stable point and this is ready to merge

CodyCBakerPhD commented 5 months ago

@bendichter OK, pinned to latest PyNWB and checked that it still works, this should be good to go