search

dandi / nwb-healthstatus

Apache License 2.0
1 stars 1 forks source link

Create new "core" NWB file #20

Closed kir0ul closed 3 years ago

kir0ul commented 3 years ago

This PR closes https://github.com/dandi/nwb-healthstatus/issues/18.

yarikoptic commented 3 years ago

@kir0ul should we consider it for merging (we might need tuneup since we are changing things)? then please move it from the Draft state

kir0ul commented 3 years ago

@kir0ul should we consider it for merging (we might need tuneup since we are changing things)? then please move it from the Draft state

I planned to add more but I'm away for a few days so I'd wait a bit if you don't mind. What do you think of the testing part so far? Can it be improved?

yarikoptic commented 3 years ago

We could wait or could just tune it up later -- having such concrete "test case" as you have it ATM would be nice. We are still thinking out how to wrap up the testing, so I would not bother improving ATM since who knows with what setup etc we end up with.

kir0ul commented 3 years ago

Could be improved but I think this starts to be ready for review.

kir0ul commented 3 years ago

Any news on this PR?

yarikoptic commented 3 years ago

Eh, we mothballed this effort until we have more time for it. I guess it wouldn't hurt to merge your PR so whenever we or nwb folks continue, your test gets attended to as well. Let's proceed