dandi / nwb-healthstatus

Apache License 2.0
1 stars 1 forks source link

CI setup #8

Open yarikoptic opened 3 years ago

yarikoptic commented 3 years ago

I think the course of action would be for now

I have used producer term above but I guess it is more of a testsuite (core, spikeextractors, etc).

With the above plan ATM we can produce a very coarse dashboard where for each environment we would be able to say only if all good for it as a whole and not per producer. I think we will work out more detailed view later, possible following #10 idea.

jwodder commented 3 years ago

@yarikoptic

yarikoptic commented 3 years ago
  • Regarding the Docker step: Since images can't be pushed to Docker Hub without first creating a repository on the Hub, I think it'd be easier to just create the images at the same time that the repositories are created (either through building & pushing from the command line or by setting up automatic builds) and not bother with having the workflow build any images.

I guess for now we could do it manually, but in the longer term I think it would be nice to have CI (not in PR but when ran in master) to take care about that. This way addition of a new environment would be as easy as editing a single file (the specification), sending a PR, seeing that it works, merging.

  • Are you sure it's a good idea for PR runs to be pushing samples to the sample repo? It seems like pushes should only be done when running on master (e.g., as a scheduled run).

correct -- any pushes (docker or datalad) should happen only from master branch (scheduled) and indeed that should avoid race condition (unless cron runs overlap)

jwodder commented 3 years ago

@yarikoptic

yarikoptic commented 3 years ago
  • Please explain, step by step, what you want the first draft of the workflows to do.

Let's start with "docker" - "produce" steps in the issue description. If any particular step is not clear - I would be happy to clarify, but need to know what is not clear.

generate ssh keypair, add secret one into secrets, public to gin, share both with me via email