search

dandi / zarr_checksum

Algorithms for calculating a zarr checksum against local or cloud storage
https://pypi.org/project/zarr-checksum/
Apache License 2.0
11 stars 3 forks source link

Support Python 3.7 #2

Closed jwodder closed 1 year ago

jwodder commented 1 year ago

In order for this to be usable in dandi-cli, it needs to work with Python 3.7+.

satra commented 1 year ago

@jwodder and @yarikoptic - i think we should drop 3.7 instead from the CLI and follow numpy's and python's deprecation policies. i'm going to drop 3.7 from dandischema as well with the next set of updates.

jwodder commented 1 year ago

@satra

python's deprecation policies

Could you elaborate on this? Python 3.7 isn't EOL until the end of June of this year.

satra commented 1 year ago

see: https://numpy.org/neps/nep-0029-deprecation_policy.html#support-table

and since we depend quite a bit on a numpy-based stack, including nibabel, nwb, pybids, it would be good to align with that.

yarikoptic commented 1 year ago

well, numpy already dropping 3.8 (in its main) scheduled to be released in July (3.8 is still supported upstream till fall of 2024). I am not entirely sure we should chase such a speedy train here -- us supporting earlier python doesn't preclude use with non-bleeding edge numpy etc as it might actually be available on the system/distribution. Insofar our policy was to support supported Pythons, and 3.7 is still well supported.

jjnesbitt commented 1 year ago

@jwodder prior to merging please run poetry version patch locally and push that commit, so the package is correctly published. I'll set up CI to catch this soon.

jwodder commented 1 year ago

@AlmightyYakob Command run, but I don't have permission to merge.