dandls / counterfactuals

counterfactuals: An R package for Counterfactual Explanation Methods
https://dandls.github.io/counterfactuals/
GNU Lesser General Public License v3.0
21 stars 4 forks source link

Commenting Conditional.R #1

Closed mb706 closed 1 year ago

mb706 commented 3 years ago

I know this is all a work in progress and I may be commenting things that you were planning to change already, but maybe I still wrote some things that are helpful. All my comments are obviously only suggestions, I am not your boss ;)

mb706 commented 3 years ago

Just click on 'files changed' and see all the comments I made so far

mb706 commented 3 years ago

See the commits in which order I went through files. I was only going superficially, so didn't really check whether the logic makes sense.

mb706 commented 3 years ago

Consider setting up CI to compute test coverage