Closed andreash0 closed 1 year ago
I agree that the current procedure involves many fields, adding an unnecessary degree of complexity.
Considering your idea, I like that the user is able to switch between all counterfactuals and only valid counterfactuals, but I am not sure if I like that flipping the value of a field triggers a set of actions and overwrites other fields.
I have the feeling that, as a user, if I want to actively change my displayed results, this should be done with a method.
Alternatives:
subset_to_valid()
and revert_subset_to_valid()
. What do you think, @andreash0?
I think your proposed solution with the two methods is great @dandls 👍
Great, I will work on it.
At the moment, we have three methods/fields for subsetting valid counterfactuals:
I was thinking if we should simplify this workflow as follows:
This way, users would only need to set one flag to use all or only valid counterfactuals.
@dandls: What do you think? :)