search

dandls / counterfactuals

counterfactuals: An R package for Counterfactual Explanation Methods
https://dandls.github.io/counterfactuals/
GNU Lesser General Public License v3.0
21 stars 4 forks source link

bbotk 0.9.0 #40

Open be-marc opened 3 months ago

be-marc commented 3 months ago

Hey,

the upcoming bbotk version 0.9.0 changes the names of some classes (see https://github.com/mlr-org/bbotk/blob/main/NEWS.md). I only found OptimInstanceMultiCrit in the counterfactuals code https://github.com/dandls/counterfactuals/blob/287a264221f0ae0784bc460346ca0ea37c2747fb/R/moc_algo.R#L52

which is OptimInstanceBatchMultiCrit now. Unfortunately, I couldn't check if it works because bbotk 0.9.0 already depends on the new paradox version 1.0.0 and counterfactuals uses the old paradox. When counterfactuals uses paradox 1.0.0 you should check of it works with bbotk 0.9.0.

be-marc commented 3 months ago

The OptimInstanceMultiCrit will continue to exist for the time being. However, the user will receive a message that OptimInstanceMultiCrit is deprecated. This should therefore be updated at some point.