search

dandls / counterfactuals

counterfactuals: An R package for Counterfactual Explanation Methods
https://dandls.github.io/counterfactuals/
GNU Lesser General Public License v3.0
21 stars 4 forks source link

GitHub paradox #41

Closed mb706 closed 4 months ago

mb706 commented 4 months ago

A new version of paradox is upcoming that makes a few breaking changes. I will also need to update miesmuschel.

I try to make sure that most packages work with both the old as well as the new paradox, this would make updating smoother: first, all dependent packages update to something that works with both old and new paradox, and then paradox can finally be updated. I therefore changed the github actions script somewhat; this can be reverted when the new paradox is on CRAN.

The main change is that the Param class ceases to exist; instead, ParamSets are now constructed using the ps(x = p_int()) syntax. It also used to be possible to inspect the Param objects inside a ParamSet through $params, which does not work any more now.

I think the code does not use $params, so only a few instances of ParamSet$new( need to be changed.

mb706 commented 4 months ago

(also ParamSet$subset() is no longer in-place)