search

dandruff / xCT

A light weight scrolling combat text implementation.
53 stars 22 forks source link

bug with icons #170

Open SumsarTheThird opened 3 years ago

SumsarTheThird commented 3 years ago

i have this issue, where even though i disable icons, there is still space left for them, messing with the allignment of the numbers.

there is 3 pictures here, to better illustrate the problem. pic 1: testmode: shown correctly, although its also still showing name there, even though that is also disabled. https://drive.google.com/file/d/1pNeL01MXJsqermN94_aCZnvDaRB-4NfI/view?usp=sharing pic 2: with icons: https://drive.google.com/file/d/1uMOM860qEgZBUJQYVxHAuu6c6XwJrpbS/view?usp=sharing pic 3: Without icons https://drive.google.com/file/d/153LCmJhSDzRHQpvbqN6CQUcRCRYEncba/view?usp=sharing

Would be absolutely magnificent if this could get fixed. your addon is perfection otherwise! keep it up!

Cimplex commented 3 years ago

Adding a new option to hide invisible "spacer" icons when Icons are disabled. Please let me know if this fixes your issue

hide invisible icons

Download here: https://github.com/dandruff/xCT/releases/tag/4.5.3-Beta1

SumsarTheThird commented 3 years ago

As far as i can tell, after running a mythic +, your toggle seems to be fixing it. for reference, here is a picture of how it looks after your fix: https://drive.google.com/file/d/1nuSaSGC4VGtJwZjMj_L81vRVjsV7IOHO/view?usp=sharing