search

dandruff / xCT

A light weight scrolling combat text implementation.
53 stars 22 forks source link

Add merging of incoming damage #185

Closed oBusk closed 3 years ago

oBusk commented 3 years ago

This adds very basic merging of incoming damage. This is most relevant for brewmaster monks since they have "stagger" which ticks damage quickly. It works with stagger as it is now.

I guess the current solution will also merge incoming damage that is merged, like from other players etc. That's maybe not expected.. Maybe should just do merging for damage where player is source?

oBusk commented 3 years ago

Something like this PR fixes #181

oBusk commented 3 years ago

Does this simple fix look correct @dandruff?

dandruff commented 3 years ago

Looks good. When I made the recent beta, I didn’t realize this this was to filter stagger for incoming damage as well. I’ll update it with this.