dandruff / xCT

A light weight scrolling combat text implementation.
53 stars 22 forks source link

XCT Lock Not working #194

Closed killahawk closed 3 years ago

killahawk commented 3 years ago

i go to resize and it locks me in the screen you cant get out of it until you reload your ui.

oBusk commented 3 years ago

I've also seen this. I noticed the lock button worked fine after resetting my profile completely.

oBusk commented 3 years ago

Error is

22x xCT+\modules\frames.lua:968: attempt to perform arithmetic on a nil value
[string "@xCT+\modules\frames.lua"]:968: in function `SaveAllFrames'
[string "@xCT+\modules\frames.lua"]:1202: in function `OnAccept'
[string "@FrameXML\StaticPopup.lua"]:5021: in function `StaticPopup_OnClick'
[string "*:OnClick"]:1: in function <[string "*:OnClick"]:1>

Locals:
self = <table> {
 SetDefaultModuleLibraries = <function> defined @ElvUI\Libraries\Ace3\AceAddon-3.0\AceAddon-3.0.lua:367
 runeIcons = <table> {
 }
 UpdateComboPointOptions = <function> defined @xCT+\core.lua:874
 OnSpamUpdate = <function> defined @xCT+\modules\frames.lua:553
 CombatStateChanged = <function> defined @xCT+\core.lua:1714
 MigratePrint = <function> defined @xCT+\core.lua:260
 EnableModule = <function> defined @ElvUI\Libraries\Ace3\AceAddon-3.0\AceAddon-3.0.lua:332
 RestoreAllDefaults = <function> defined @xCT+\modules\frames.lua:1188
 baseName = "xCT+"
 IterateEmbeds = <function> defined @ElvUI\Libraries\Ace3\AceAddon-3.0\AceAddon-3.0.lua:442
 EndConfigMode = <function> defined @xCT+\modules\frames.lua:858
 Clear = <function> defined @xCT+\modules\frames.lua:274
 Printf = <function> defined @ElvUI\Libraries\Ace3\AceConsole-3.0\AceConsole-3.0.lua:69
 CombatLogEvent = <function> defined @xCT+\modules\combattext.lua:1930
 SetDefaultModulePrototype = <function> defined @ElvUI\Libraries\Ace3\AceAddon-3.0\AceAddon-3.0.lua:409
 player = <table> {
 }
 defaultModuleState = true
 IsEnabled = <function> defined @ElvUI\Libraries\Ace3\AceAddon-3.0\AceAddon-3.0.lua:451
 GenerateColorOptions = <function> defined @xCT+\core.lua:1544
 merge = <unnamed> {
 }
 Abbreviate = <function> defined @xCT+\modules\frames.lua:301
 GetArgs = <function> defined @ElvUI\Libraries\Ace3\AceConsole-3.0\AceConsole-3.0.lua:144
 frames = <table> {
 }
 FrameTitles = <table> {
 }
 LoadAlignmentGrid = <function> defined @xCT+\modules\grid.lua:23
 db = <table> {
 }
 ToggleConfigMode = <function> defined @xCT+\modules\frames.lua:929
 QuickClassFrameUpdate = <function> defined @xCT+\modules\combattext.lua:723
 SetEnabledState = <function> defined @ElvUI\Libraries\Ace3\AceAddon-3.0\AceAddon-3.0.lua:424
 UpdateBlizzardFCT = <function> defined @xCT+\modules\blizzard.lua:74
 enabledState = true
 UpdateCombatTextEvents = <function> defined @xCT+\modules\combattext.lua:137
 EnableFrameScrolling = <function> defined @xCT+\modules\frames.lua:252
 configuring = true
 AlignGrid = <unnamed> {
 }
 OnCombatTextEvent = <function> defined @xCT+\modules\combattext.lua:538
 UpdatePlayer = <function> defined @xCT+\modules\combattext.lua:109
 IterateModules = <function> defined @ElvUI\Libraries\Ace3\AceAddon-3.0\AceAddon-3.0.lua:437
 events = <table> {
 }
 waiterHideConfig = <unnamed> {
 }
 GetSpellSchoolColor = <function> defined @xCT+\core.lua:1610
 UpdateSpamSpells = <function> defined @xCT+\core.lua:517
 myContainer = <table> {
 }
 UpdateItemTypes = <function> defined @xCT+\core.lua:727
 isConfigToolOpen = false
 OnEnable = <function> defined @xCT+\core.lua:1695
 lowMana = false
 inCombat = false
 Enable = <function> defined @ElvUI\Libraries\Ace3\AceAddon-3.0\AceAddon-3.0.lua:294
 NewModule = <function> defined @ElvUI\Libraries\Ace3\AceAddon-3.0\AceAddon-3.0.lua:235
 lowHealth = false
 combatEvents = <unnamed> {
 }
 existingProfile = <table> {
 }
 DisableFrameScrolling = <function> defined @xCT+\modules\frames.lua:259
 TrackxCTCommand = <function> defined @xCT+\core.lua:1928
 HideConfigTool = <function> defined @xCT+\core.lua:1903
 OnAddonConfigRefreshed = <function> defined @xCT+\core.lua:1751
 defaultModuleLibraries = <table> {
 }
 ShowConfigTool = <function> defined @xCT+\core.lua:1845
 GetSpellTextureFormatted = <function> defined @xCT+\modules\combattext.lua:584
 UnregisterChatCommand = <function> defined @Inte
oBusk commented 3 years ago

https://github.com/dandruff/xCT/blob/4.5.5-Beta2/modules/frames.lua#L968 From what I can tell, the frame:GetLeft() and frame:GetTop() both returns nil for my loot frame. Which I have disabled. So disabled frames breaks it. If all frames are left enabled, like if you've reset your entire profile, works. Maybe just skipping frames that are disabled would be enough?