search

dandruff / xCT

A light weight scrolling combat text implementation.
53 stars 22 forks source link

Add merges and a few DF trinkets + Enchants + Legendary #236

Closed RedAces closed 4 months ago

RedAces commented 5 months ago

The merges are checked by me using chars of myself, so they should be good. I did not cleanup all the old IDs, maybe that should be done sometimes in the future?

Re: the DK Runes fix: it seems like the slot # is getting negative. Why? IDK, I just added the catch clause. It would be worth investigating why its getting negative though.

For the vigor change: Just adding this to the global array fixed the error, IDK what else would be necessary to properly add xct notifications for gaining a vigor charge.

RedAces commented 4 months ago

Ive gone through some issues and added merges for them.

Lemme know how I can help.

Id propose a generic merger: just merge all instances of the same spell (ID) within a certain time period (e. g. 1 GCD or 0.5 sec?) automatically without any configuration. The current config can still override it and add aliases or increase the merge period.

Im not sure that I can do that yet (my LUA is very limited) :D

Cimplex commented 4 months ago

thank you! I meant to get to this sooner, going to make a new beta release right now