search

dandruff / xCT

A light weight scrolling combat text implementation.
53 stars 22 forks source link

Merge all spells/items/enchants #238

Closed RedAces closed 1 month ago

RedAces commented 4 months ago

This has all changes from https://github.com/dandruff/xCT/pull/237 too. Sorry!

This PR changes so that EVERY spell gets merged with a 0.5 interval. You can still define a higher interval in the merge_*.lua, but the default value is 0.5 sec for everything.

Ive gone and deleted all spells and items that had a 0.5 merge interval.

Let me know what you think!

RedAces commented 4 months ago

In the options, you can uncheck spells for merging. Does it actually get a use or is this just for legacy reasons?

The problem with my changes is, that you cant actually disable the merging of a certain spell. Even if you disable it in the options, it will still get merged.

So is this a functionality that you want to preserve?

For my part: I think if spell merging is enabled, then everything should get merged. Theres no reason to have exactly one spell spam your whole output frame but merge all others. Big improvement of merging everything: the amount of maintenance you have to do (as addon author) after every patch / expansion drops significantly...

If you agree, then I guess removing these checkboxes would be the logical next step. If you disagree, lets talk about how we can have the auto-merge functionality with the possibility to disable the merging of certain spells.