Absorbations

[Tonyleila]

1. You added an option to Hide Blizzards new Absorb Combat text that pops up if you give other players absorbs but I can't find an option to show this in xCT. Its silly to use blizzards-ct and xCt+ together just to get all infos. So is it possible to fix this?
2. As said in Issue #38 the absorbation on myself is not showing up if everything is absorbed - is this still not easy fixable with the changes of 5.4?

[dandruff]

Just to give a quick update. Parsing for absorbs on other players is semi-difficult, but not impossible, because I have to start looking at the combat log. I am not sure if I will have to be scanning for Auras or if Blizzard provides an event for it. Like you said, there are new changes that came in 5.4, but I'll have to look at them again.

Either way, when I get on my computer later I'll start looking at this.

I still am in the mindset that issue #38 will have to wait for 4.0, but I will also look at it again when I check out the "outgoing absorbs."

Thanks for the requests though, keep them coming! :)

[dandruff]

All right, I finally had a chance to really examine what was added in the last patch. I'll be going over several things more for my benefit when I forget about what I found in the next 5 minutes :)

First to address issue #38, which is to show the value of absorbed damage if all damage taken was absorbed (e.g. You have a 200k shield, and you take 180k damage. Currently shows "Absorbed", should show "-180K (Absorbed)"). I currently have the capability to implement something like this. The only caveat that I can see at this point is that when an absorb falls off, because an aura expired, opposed to damage taken, it will appear as though you took that much damage. I know this is confusing so here's an example:

Dandruff casts Power Word: Shield -> Tonyleila for 180K
Tonyleila takes 100K Damage
Power Word: Shield fades from Tonyleila

Tonyleila will have gotten 2 damage events. One for 100K (all of which was absorbed) and one for 80K (this is because PW: S fell off of Tony). Currently, I can't think of a way around this issue, but at the same time, I don't really think it is that big of a deal, since you are losing that much "health" anyway. This is all thanks to the new event "UNIT_HEAL_ABSORB_AMOUNT_CHANGED" which allows me to cache your total absorbs and keep track of and inform the player when it changes for himself. All that to say, I think I will be implementing this into a developer version and possibly putting it in a beta.

Even though to appears that "UNIT_HEAL_ABSORB_AMOUNT_CHANGED" also fires for people in your group, it does not include who is the source of such an event. Meaning that I still won't be able to show when you place a shield on someone, unless I was to track auras. Something I could do, but would require a significant involvement on my part. As of right now, I am not sure if this will be a 4.0 feature or if I can implement it sooner, since most of the code required will be future proof anyways.