dandruff / xCT

A light weight scrolling combat text implementation.
53 stars 22 forks source link

Item Quality in colorblind mode is wrong #5

Closed Joschasa closed 13 years ago

Joschasa commented 13 years ago

local itemQualities={'Poor','Common','Uncommon','Rare','Epic','Legendary','Artifact','Heirloom'} s = item.type.." ("..itemQualities[item.quality].."): ["..item.name.."] "

item.quality begins at Poor == 0 itemQualities has Poor == 1 For example it will output "Poor", when item is common

btw to get localised strings, you could use ITEM_QUALITY0_DESC = "Poor"; to ITEM_QUALITY7_DESC = "Heirloom";

dandruff commented 13 years ago

Thanks for pointing this out! (Our colorblind friends probably hate me). I'll get this updated as soon as possible.

dandruff commented 13 years ago

The latest commit attempts to fix this issues, found here. I'm going to leave this open until I can test the changes.

Cimplex commented 13 years ago

This issue appears to be fixed. Closing.

<3 the Colorblind