search

dandruff / xCT

A light weight scrolling combat text implementation.
53 stars 22 forks source link

Blizzard config adjustments #63

Closed ckaotik closed 9 years ago

ckaotik commented 9 years ago

Hey dandruff,

I figured we didn't need to alter the Blizzard config right away, without it even being shown. Therefore I moved this into a wrapper function that gets called on the panel's OnShow. Might mean the code runs multiple times, but then, the config is always meant to be disabled with xCT loaded and the frames are only created once. This also helped be reduce taints since once you even glance at an UIDropDown, the whole UI goes crazy. Delaying this involvement did help in my case, since if you don't open the panel, there are no changes made :)

Regarding "disabled": I personally don't like not seeing anything in that tab. So I simply disabled the controls instead of hiding them. This brings the added bonus that the code does not need to be updated whenever Blizzard adds a new setting to the panel.

bildschirmfoto 2015-04-09 um 10 05 27

Cimplex commented 9 years ago

I love the idea! I was having some problems with it. First, if you click "OK" from that screenshot, and then immediately click on "Interface" from the game menu again, do some of the check boxes not disable for you?

I'm trying to look into why that is happening for me:

https://dl.dropboxusercontent.com/u/8093066/Photos/xct_plus_config_bug.PNG

Then there is the "1" text instead of "Shields". I have no idea where that is coming from.

So I am going to have to do more research before I can merge this.

Keep up the good work though! Let me know if you figure anything out on your side.

ckaotik commented 9 years ago

Okay, so I got the disabled state not sticking around during refreshs fixed. The other issue comes from another component: The checkbox displays the value of SHOW_COMBAT_HEALING_ABSORB_SELF (as seen here) which you yourself set to "1" or "0" respectively here ;)

Why exactly do you change these globals? Shouldn't setting the CVars be enough? Edit: I've removed most of the global string changes on my end, and haven't had any issues. However, that's just my setup :)

Cimplex commented 9 years ago

Nice! Ugh, I was hoping to get to this this weekend. We will see. Thanks Ckaotik!

Cimplex commented 9 years ago

Absolutely amazing! Thanks ckaotik