Open ghost opened 9 years ago
Hi Jonas,
Thanks for the offer to help; PRs would be appreciated.
As for where exactly to contribute the code, I hope that @mkozhukh will help unify the repositories. Right now we have three repos:
My suggestions:
.js
file, with the proxy (now in webix-meteor-data) and Blaze template rendering (now in webix-meteor-example).@mkozhukh, what do you think?
I think the pro version of Webix has more features and the additional components (pivot table etc.). I'm not sure if the additional features are stripped out from the webix-hub/tracker repository.
So I would suggest to have a separate Webix wrapper package and one or more additional Webix Meteor integration packages that depend on the Webix wrapper package. Users of the pro version could clone this wrapper package as local package and replace the webix files with the pro version.
I've done this structure for the current project I work on already:
@mkozhukh Is the https://github.com/webix-hub/webix-meteor-example also under MIT license? The license is missing right now.
@Sanjo: good point re. the Pro version. This repo is indeed structured to include Webix and the adapter as two submodules, and a Pro user could overwrite webix_debug.js
in the webix submodule with the Pro version.
If the webix-meteor proxy adapter needs any extra code for the Pro widgets, that code could still go in the same adapter file, since it will be relatively very small by comparison to the size of the library itself (unless the adapter code somehow needs any part of the Pro version to be already instantiated, which I doubt is the case).
In any case, we can at least unify webix-meteor-data and webix-meteor-example, since the latter includes everything in the former, and fixes the example.
Seems best to have a single repository as the source for the integration
I'm agree about merging webix-meteor-data and webix-meteor-example in this repo.
Is the https://github.com/webix-hub/webix-meteor-example also under MIT license
Yes. All projects except of main Webix repo are under MIT license. I will update readme files to make it clear.
If the webix-meteor proxy adapter needs any extra code for the Pro widgets
While PRO version has some extra widgets it uses the same code for data loading as GPL version. There will be no need for PRO-related modifications in data-adapter.
About "routing with Webix layout"
As far as I can see there are two possible solution:
Hi Dan,
just wanted to let you know that I currently look for a solution for that. I can contribute the solution to this repository if you like.
What I have done:
{{> Router}}
for iron:router