Cleanup hardcoded clientID

daneden / Twift

🐦 An async Swift library for the Twitter v2 API 🚧 WIP

MIT License

111 stars 25 forks source link

Cleanup hardcoded clientID #20

Closed emin-grbo closed 2 years ago

emin-grbo commented 2 years ago

Not sure if this was left by accident?

emin-grbo commented 2 years ago

I so forgot about this PR 😅 and life got a bit crazy. For you too I imagine :) So, I just need to define a key that will be used instead like: CLIENT_ID?

daneden commented 2 years ago

@roblack yep, that's right! It’ll need adding to the .env.example and the pre-action build script which you can find in Xcode’s Scheme Editor. If I get time later I can work on this myself.

emin-grbo commented 2 years ago

Hm...I tried to find it but not really sure this is it. When I inspected the scheme I did not find any scripts I could ament. 🤷‍♂️

daneden commented 2 years ago

Committed on your branch, that should do the trick!