danenders
commented
1 year ago An issue with the battle engine. Probably beyond my paygrade to fix / merging would be difficult with how out of date PokeClassic's base is. Going to pass on this.
Closed DaniRainbow closed 1 year ago
danenders
commented
1 year ago An issue with the battle engine. Probably beyond my paygrade to fix / merging would be difficult with how out of date PokeClassic's base is. Going to pass on this.
DaniRainbow
commented
1 year ago For the ones that you won't fix but would be in the spirit of the hack, would you merge pull requests? I don't mind taking a crack at some of these like I am with the Moltres issue but if pull requests are always going to be closed on principle instead of merged I may just post how I fixed things instead. I appreciate your hard work on this hack, just curious if you would accept contributions to the code or if it's a solo endeavor.
On Fri, Aug 11, 2023, 8:26 AM danenders @.***> wrote:
Closed #104 https://github.com/danenders/pokeclassic/issues/104 as not planned.
— Reply to this email directly, view it on GitHub https://github.com/danenders/pokeclassic/issues/104#event-10070374761, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXDPAMUCK2PK6CEF6GWBPFTXUY6IVANCNFSM6AAAAAA2ZRJ2EQ . You are receiving this because you authored the thread.Message ID: @.***>
danenders
commented
1 year ago So some of the ones that I closed the pull requests for were because they were known issues and I had already been working on my changes locally; so going forward, once I knock out most of these reported/investigated ones, I don't think I'd be opposed to accepting merges!
I'm going to try and hit the last few big ones (Mewtwo, Moltres, and Cedar), but after that I likely won't be doing many fixes/investigating on my own.
Basically, once I'm done with some of the stuff I already know how to fix and just need to get around to it, it'll stop being "solo". I've really appreciated all your work testing/hunting bugs, too.
DaniRainbow
commented
1 year ago Cool, thanks for letting me know
On Fri, Aug 11, 2023, 9:04 AM danenders @.***> wrote:
So some of the ones that I closed the pull requests for were because they were known issues and I had already been working on my changes locally; so going forward, once I knock out most of these reported/investigated ones, I don't think I'd be opposed to accepting merges!
I'm going to try and hit the last few big ones (Mewtwo, Moltres, and Cedar), but after that I likely won't be doing many fixes/investigating on my own.
— Reply to this email directly, view it on GitHub https://github.com/danenders/pokeclassic/issues/104#issuecomment-1674936714, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXDPAMT37TVISN2UKDSAYMLXUZCZHANCNFSM6AAAAAA2ZRJ2EQ . You are receiving this because you authored the thread.Message ID: @.***>
While going through Victory Road with a Dig using Sandslash, Machoke would constantly hit Sandslash underground when using the move Dual Chop. As far as my understanding goes, Dual Chop does not burrow into the ground and Machoke does not have an ability to hit pokemon off screen. Needs further research, if anyone wants to test this I would appreciate it.