search

danenders / pokeclassic

PokeClassic is a romhack inspired by Pokemon Yellow, using the Pokemon Emerald Engine.
50 stars 12 forks source link

Bug: Moltres missing from Victory Road #66

Closed ttdevmode93 closed 1 year ago

ttdevmode93 commented 1 year ago

image

The cave in the back of the pic can't be entered either. I have beaten the elite 4, if that matters.

ZhugeLain commented 1 year ago

image

The cave in the back of the pic can't be entered either. I have beaten the elite 4, if that matters.

How do you get to this spot in VR?

ttdevmode93 commented 1 year ago

Just go to the place where Moltres usually is in Yellow, and you'll see it.

DaniRainbow commented 1 year ago

I'm currently investigating this issue. The warp Event on the cave door is properly pointing to the room Moltres is in and the collision detection is no different from other caves but the player cannot walk into the cave door tile and activate the warp. I changed the collision to match a door and put a door tile there and in the compilation, the door did not appear but all ladders in Victory Road went to the bottom right ladder of Victory Road 2F. Opening the file in porymap shows that the ladder warps are still pointing to the right places so something is not quite right. This is my priority issue because this is now the only thing preventing a player from completing the Pokedex.

DaniRainbow commented 1 year ago

Good news: I was able to find collision detection and a cave entrance tile that allows a player to enter in to Moltres's room and catch the Moltres.

Bad news: Despite not changing ANY of the warps, most ladders and doors are now bugged. Exiting Moltres room leads to the first 2F ladder, going down that ladder leads to the Victory Road entrance, going out of Victory Road teleports the player to the south side of Route 23. I ran around Viridian City and Pallet Town to see if anywhere else got messed up warps but thankfully the issue is contained to the Victory Road maps.

In Yellow, I believe Moltres was just in the crater of Victory_Road_2F instead of in a separate room. Perhaps it would be better to remove this extra chamber and re-create the Pokemon Yellow interaction?

Found this image confirming Moltres was not in a separate chamber. https://cdn.wikimg.net/en/strategywiki/images/b/be/Pokemon_RBY_VictoryRoad_F2.png?20070624175542

MrMazzone commented 1 year ago

My vote goes to we have Moltres appear in the crater. Would it be with a flag that you have to be champion for Moltres to appear?

DaniRainbow commented 1 year ago

My vote goes to we have Moltres appear in the crater. Would it be with a flag that you have to be champion for Moltres to appear?

I believe that wasn't a requirement in Yellow but I may be mistaken. The Moltres encounter in the chamber is formatted differently than Zapdos and Articuno but it should be possible to add those script options to the Victory Road with some changes, including moving two items. I'll start trying to merge the scripts as I can.

danenders commented 1 year ago

This has been fixed. Changed the tiles a bit, but Moltres' room is now accessible.

DaniRainbow commented 1 year ago

Did you happen to test if the warps get messed up in Victory Road? If not I can compile this latest one and check.

On Sat, Aug 12, 2023, 2:48 PM danenders @.***> wrote:

Closed #66 https://github.com/danenders/pokeclassic/issues/66 as completed.

— Reply to this email directly, view it on GitHub https://github.com/danenders/pokeclassic/issues/66#event-10078075105, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXDPAMRND6RNXQLZP7LJIA3XU7TZFANCNFSM6AAAAAAZHGWEOE . You are receiving this because you commented.Message ID: @.***>

danenders commented 1 year ago

Warps should remain intact.

DaniRainbow commented 1 year ago

I'll test this when I can. Any effort I made ruined the warps even though porymap indicated no changes were made to them

On Sat, Aug 12, 2023, 6:22 PM danenders @.***> wrote:

Warps should remain intact.

— Reply to this email directly, view it on GitHub https://github.com/danenders/pokeclassic/issues/66#issuecomment-1676158708, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXDPAMSYL4NW5DRRGXROUSLXVAM4NANCNFSM6AAAAAAZHGWEOE . You are receiving this because you commented.Message ID: @.***>

danenders commented 1 year ago

No rush; but wait a day or two and I should have a version pushed up that also has the aide calls fixed. I think the last big thing I need to knock out is the softlock in Seafoam.

DaniRainbow commented 1 year ago

Cool! I'll wait till I hear back.

On Sat, Aug 12, 2023, 7:27 PM danenders @.***> wrote:

No rush; but wait a day or two and I should have a version pushed up that also has the aide calls fixed. I think the last big thing I need to knock out is the softlock in Seafoam.

— Reply to this email directly, view it on GitHub https://github.com/danenders/pokeclassic/issues/66#issuecomment-1676175792, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXDPAMQHX55FA5URDNP3IBTXVAURNANCNFSM6AAAAAAZHGWEOE . You are receiving this because you commented.Message ID: @.***>

DaniRainbow commented 1 year ago

Definitely fixed. I also didn't experience any of the previous warp issues. Thanks!

https://imgur.com/a/Oc3aWgw