search

daneren2005 / Subsonic

Home of the DSub Android client fork
GNU General Public License v3.0
582 stars 162 forks source link

Opus replaygain doesn't work if both replaygain and R128 tags present #1141

Closed dblacknc closed 1 year ago

dblacknc commented 1 year ago

There was a previous issue about opus and replaygain, and that R128 tags work. I confirm this - however if both R128 and the REPLAYGAIN* or replaygain* tags are present, DSub treats it as non-replaygain. Since R128 tag(s) are there, I expect it'd work; the presence of others wouldn't break it.

dblacknc commented 1 year ago

Scratch that - what I'm seeing is pretty squirrely, as to what does and doesn't work with replaygain/R128 tags. With seemingly same set of tags and format, some files work and some don't. I'll have a look at the source code and open a new issue if/as appropriate.