search

danesparza / MailChimp.NET

:envelope: .NET Wrapper for the MailChimp v2.0 API
MIT License
179 stars 119 forks source link

Naming suggestions for the Gallery methods #106

Closed SteveVaneeckhout closed 9 years ago

SteveVaneeckhout commented 10 years ago

I'm implementing the gallery methods. The problem with these methods is that they contain the word Folder and there are already Folder methods implemented. To minimize confusion I would use the word Gallery in all methods. I'm open for other suggestions, here's what I came up with:

Already implemented

New methods

danesparza commented 10 years ago

I think your suggestions are reasonable (I think Visual Studio intellisense will filter methods shown to 'gallery' methods if you just type .gallery right?)

I'm wondering if we should make a change to prefix folder methods with 'Folder' and gallery methods with 'Gallery'... so that would make AddFolder become 'FolderAdd' and AddGalleryFolder would become GalleryFolderAdd. Thoughts?

SteveVaneeckhout commented 10 years ago

Your first statement is correct. Typing .gallery is going to display all gallery methods. I love that feature in VS.

Those names don't sound very natural but it does make them more clear that they are part of the gallery methods. Let's see what others have to say about this. I still need to implement the test code and test it all before I do a pull request.