search

danesparza / domainname-parser

:department_store: .NET domain name parsing library (uses publicsuffix.org)
MIT License
35 stars 19 forks source link

Fix namespace issue ? #7

Closed YakupIpek closed 8 years ago

YakupIpek commented 8 years ago

I like the library and it seems it does the job pretty well, thanks for it. But one thing is quite annoying. I can not use DomainName class without specifying full namespace prefix as below. 

            DomainName.Library.DomainName domain;
            if (DomainName.Library.DomainName.TryParse("http://www.domain.com", out domain))
                return domain;

My suggestion is rename DomainName.Library as DomainParser and i also suggest rename DomainName as Domain.

Thanks

CREFaulk commented 8 years ago

Me too! jk This was also the first thing I noticed about the library.

danesparza commented 8 years ago

Great suggestion! I'll see if I can get to that soon.

I also accept pull requests. :smile:

CREFaulk commented 8 years ago

Perhaps PublicSuffix.Library as a namespace? It'd require nuget downloaders to update their code though.

danesparza commented 8 years ago

Thanks for the suggestions -- I have refactored the projects and updated the NuGet package.

CREFaulk commented 7 years ago

Thanks for this!