danfairs / django-lazysignup

django-lazysignup is a package designed to allow users to interact with a site as if they were authenticated users, but without signing up. At any time, they can convert their temporary user account to a real user account.
BSD 3-Clause "New" or "Revised" License
410 stars 89 forks source link

Nice username generation #35

Closed aladagemre closed 4 years ago

aladagemre commented 11 years ago

Current username generation produces disturbing random strings.

Another approach could be in the form of user-%d like user-0 user-1 user-2 where integer is the latest lazy user's pk + 1. This will be more user-friendly I think.

If you think that any problems could arise with this approach, feel free to change it.

danfairs commented 11 years ago

Thanks for the PR!

I don't think I want to do this unconditionally. There's some work going on to make lazysignup play more nicely with Django 1.5's pluggable user models. I'm pretty sure that work makes the LazyUser model optional (as long as you're using a custom User model), so I don't want to add any more dependencies on it. @aStoneCutter - any thoughts?

(As an aside, I'd want to see tests included for something like this to be merged.)

aladagemre commented 5 years ago

It's been quite a while but if it's not a relevant feature, you may close the PR or evaluate it.