search

danfairs / django-lazysignup

django-lazysignup is a package designed to allow users to interact with a site as if they were authenticated users, but without signing up. At any time, they can convert their temporary user account to a real user account.
BSD 3-Clause "New" or "Revised" License
410 stars 89 forks source link

LazyUser.user attribute needs on_delete argument for Django>=2.0 #59

Closed LaundroMat closed 6 years ago

LaundroMat commented 6 years ago

After installing and running the server, a TypeError error is raised in "lazysignup\models.py", line 81, in LazyUser

TypeError: __init__() missing 1 required positional argument: 'on_delete'

LazyUser.user needs the on_delete argument which I've added.

LaundroMat commented 6 years ago

Sorry, I didn't realise I was stepping into a full Django 2.0 upgrade here. I'll try and work on it some more before issuing a PR.

philmaweb commented 6 years ago

Hi, I'm also looking into django 2.0 support, any progress so far since your pr?

LaundroMat commented 6 years ago

No, sorry. I didn't find the time.

LaundroMat commented 6 years ago

Hi @philmaweb , I've found some to work on this and have created a PR for Django 2.0 and higher. It is no longer backwards-compatible however.