Removing list comprehension to allow for short circuit evaluation - Githubissues

danforthcenter / plantcv

Plant phenotyping with image analysis

Mozilla Public License 2.0

665 stars 265 forks source link

Removing list comprehension to allow for short circuit evaluation #1494

Closed natejly closed 7 months ago

natejly commented 7 months ago

Describe your changes Removing list comprehension to allow for short-circuit evaluation

For the reviewer See this page for instructions on how to review the pull request.

[ ] PR functionality reviewed in a Jupyter Notebook
[ ] All tests pass
[ ] Test coverage remains 100%
[ ] Documentation tested
[ ] New documentation pages added to plantcv/mkdocs.yml
[ ] Changes to function input/output signatures added to updating.md
[ ] Code reviewed
[ ] PR approved

deepsource-io[bot] commented 7 months ago

Here's the code health analysis summary for commits 7e0a54f..bd373f3. View details on DeepSource ↗.

Analysis Summary

Analyzer	Status	Summary	Link
Python	✅ Success	🎯 8 occurences resolved	View Check ↗
Test coverage	✅ Success		View Check ↗

Code Coverage Report

Metric	Aggregate	Python
Branch Coverage	100%	100%
Composite Coverage	99.7%	99.7%
Line Coverage	99.7%	99.7%
New Branch Coverage	100%	100%
New Composite Coverage	100%	100%
New Line Coverage	100%, ✅ Above Threshold	100%, ✅ Above Threshold

💡 If you’re a repository administrator, you can configure the quality gates from the settings.