Closed k034b363 closed 4 months ago
Here's the code health analysis summary for commits 1672a95..49753e0
. View details on DeepSource ↗.
Analyzer | Status | Summary | Link |
---|---|---|---|
Python | ✅ Success | View Check ↗ | |
Test coverage | ✅ Success | View Check ↗ |
Metric | Aggregate | Python |
---|---|---|
Branch Coverage | 100% | 100% |
Composite Coverage | 100% | 100% |
Line Coverage | 100% | 100% |
New Branch Coverage | 100% | 100% |
New Composite Coverage | 100% | 100% |
New Line Coverage | 100%, ✅ Above Threshold | 100%, ✅ Above Threshold |
💡 If you’re a repository administrator, you can configure the quality gates from the settings.
Sample image and notebook for testing in data_science drive in jupyter/filter_objs
@k034b363 is the updated function name okay? I figure since it is in the filters
submodule we can exclude filter
in the function name. So now it would "read" pcv.filters.obj_props
@k034b363 is the updated function name okay? I figure since it is in the
filters
submodule we can excludefilter
in the function name. So now it would "read"pcv.filters.obj_props
Yep, that makes sense! I didn't choose the name with any reasoning or logic, I like the change better
Describe your changes Taking the logic of existing filter on eccentricity, this function expands to allow filtering on any numeric (float or int) object property calculated by
skimage.measure.regionprops
. The default threshold is 0 andcut_side="upper"
, which will filter nothing for most (but not all) properties. Users can also specify keeping objects below the given threshold by settingcut_side
to "lower".Type of update Is this a:
Associated issues This closes #1553
Additional context Add any other context about the problem here.
For the reviewer See this page for instructions on how to review the pull request.
plantcv/mkdocs.yml
updating.md