search

danfragoso / thdwb

🌭 The hotdog web browser and browser engine 🌭
MIT License
1.12k stars 58 forks source link

Assets error when running `make` #27

Closed AbhayAysola closed 3 years ago

AbhayAysola commented 3 years ago

# github.com/danfragoso/thdwb/mustard ../go/src/github.com/danfragoso/thdwb/mustard/tree.go:18:30: undefined: assets.DownChevron ../go/src/github.com/danfragoso/thdwb/mustard/tree.go:19:31: undefined: assets.RightChevron Makefile:11: recipe for target 'run' failed make: *** [run] Error 2

danfragoso commented 3 years ago

Sorry for the delayed answer, can you give more info about the environment where this bug was found? Operating System, Shell, Make and GO versions?

AbhayAysola commented 3 years ago

OS - Ubuntu-18.04 (WSL) Shell - Bash Make - 4.1 Go - go1.10.4

Sorry for the delayed answer

No problem

Nv7-GitHub commented 3 years ago

I'm getting this error too

Nv7-GitHub commented 3 years ago

I have the images, but the functions aren't in the assets module.

Nv7-GitHub commented 3 years ago

It seems like bundleAssets has to run. After running

go run assets/bundler.go

It compiled!

Nv7-GitHub commented 3 years ago

And it worked (aside from it showing in bottom quarter, that's a HiDPI issue)! I may make a PR converting the assets from the bundler into using Go's embed package.

Nv7-GitHub commented 3 years ago

Made a PR - https://github.com/danfragoso/thdwb/pull/29 Also, when running make build, you won't get this error, I just got it because I used the go build command.

danfragoso commented 3 years ago

Thanks for taking the time to work on this issue!

AbhayAysola commented 3 years ago

Cool!