search

danfran / hcoord

Easily convert between latitude/longitude, Universal Transverse Mercator (UTM) and Ordnance Survey (OSGB) references with Haskell.
Other
5 stars 2 forks source link

Suggestion: split hcoord package to remove dependency on regex-pcre. #1

Open philderbeast opened 6 years ago

philderbeast commented 6 years ago

Please consider splitting this package. The dependency on regex-pcre is a problem for building on Windows.

Configuring regex-pcre-0.94.4...
Cabal-simple_Z6RU0evB_2.0.1.0_ghc-8.2.2.exe: Missing dependency on a foreign
library:
* Missing C library: pcre

Module MGRSRef and no other imports Text.Regex.PCRE.

I could see it being split coarsely into hcoord and hcoord-mgrs or more finely with a package for each reference, hcoord, hcoord-utm, hcoord-osgb, hcoord-irish and hcoord-mgrs.

danfran commented 6 years ago

I am not able to verify the build under Windows and unfortunately looks like Travis-CI cannot run against Windows. I am generally agree to split the project in multiple exec like you did (thank you) but I am not sure how that it meant to solve the problem with "PCRE" on Windows.

I think it is a missing foreign library (pcre in this case) that needs to be compiled and installed on the windows instance first.

philderbeast commented 6 years ago

Of the split packages, I only require hcoord and hcoord-utm and these don't depend on regex-pcre. This fixes the problem I had building on Windows.