search

danfromtitan / envars-from-node-labels

Export container environment variables from K8s node labels
Apache License 2.0
24 stars 4 forks source link

Configurable namespace selector label #19

Closed rbarabas closed 1 year ago

rbarabas commented 1 year ago

Thanks for writing this utility! I'm surprised that this issue has not come up more frequently in the community as for stateful workloads knowing more about placement could be vital.

Our version of EKS has a different namespace selector label which makes the webhook configuration fail to match the proper events.

This PR makes the NS selector label configurable but uses the old setting ("name") as the default.

rbarabas commented 1 year ago

I just noticed that this PR includes the merge commit of our fork's PR. Let me know if you prefer a cleaner PR with a single commit!

danfromtitan commented 1 year ago

Looks good, thanks for the PR